@0xmiroslav Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

PR is ready for review @0xmiroslav

Hi @thienlnam
Need your input on this issue,

what we are dealing with is the top down transition on multiline inputs where we set focus using the ref and set cursor and scroll all together. The transition's (which is the actual bug report) RCA is that focus is set immediately and cursor is set using selection range and scroll is also adjusted together, so by the time second and third operations complete, the field is already in focus and after completion of other operations, we see the top down transition.

The solution I came up with is setting the cursor and scroll as soon as input ref is available but set the focus after the transition delay, which is in line with the newly agreed focus logic here and correct solution wrt the rca

https://expensify.slack.com/archives/C01GTK53T8Q/p1694660990479979

But the problem is that scroll does not work in native iOS platform which is an RN bug (I suppose, got insights from this PR: #20836 ) and this scroll issue for ios is still persistent in the app along with the top down transition for all platform.

Now we have 2 ways: either we let the ios issue be and wait for the real fix to come regarding the scroll and continue with the top down transition fix on all other platforms,
or we handle ios case separately by focusing it instantly without any delay (it seems to be working on ios) together with the main top down issue fix

(these are the options which we have as per mine and @0xmiroslav 's debugging)

you can see the pr for reference, holding this PR on your response

@0xmiroslav @thienlnam

let me know your thoughts so we can proceed

Adding my cents here:

• either we let the ios issue be and wait for the real fix to come regarding the scroll and continue with the top down transition fix on all other platforms,
  pros: don't put workaround
  cons: doesn't fix iOS scrolling issue

• or we handle ios case separately by focusing it instantly without any delay (it seems to be working on ios) together with the main top down issue fix
  pros: platform consistency, fixes all platforms including iOS
  cons: workaround, focus() is called twice (immediate & after setTimeout) though not affect the behavior

Friendly reminder @thienlnam

Thanks for the summary - let's go with option 2 so we fix the mentioned bug and then create a separate tracking issue for the iOS scrolling issue and add comments in the code about why we're doing this and link to the tracking issue.

Got it, will amend the PR accordingly

Got it, will amend the PR accordingly

ok please let me know when ready

on it now @0xmiroslav

pr is ready for review, tests passed @0xmiroslav

done @0xmiroslav

@chiragxarora please fix conflict

done @0xmiroslav , pls check again

Reviewer Checklist

• I have verified the author checklist is complete (all boxes are checked off).
• I verified the correct issue is linked in the ### Fixed Issues section above
• I verified testing steps are clear and they cover the changes made in this PR
  • I verified the steps for local testing are in the Tests section
  • I verified the steps for Staging and/or Production testing are in the QA steps section
  • I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
  • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
• I checked that screenshots or videos are included for tests on all platforms
• I included screenshots or videos for tests on all platforms
• I verified tests pass on all platforms & I tested again on:
  • Android / native
  • Android / Chrome
  • iOS / native
  • iOS / Safari
  • MacOS / Chrome / Safari
  • MacOS / Desktop
• If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
• I verified proper code patterns were followed (see Reviewing the code)
  • I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
  • I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
  • I verified that comments were added to code that is not self explanatory
  • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
  • I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
  • I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
  • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
  • I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
  • I verified the JSDocs style guidelines (in STYLE.md) were followed
• If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
• I verified that this PR follows the guidelines as stated in the Review Guidelines
• I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
• I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
• I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
• If a new component is created I verified that:
  • A similar component doesn't exist in the codebase
  • All props are defined accurately and each prop has a /** comment above it */
  • The file is named correctly
  • The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
  • The only data being stored in the state is data necessary for rendering and nothing else
  • For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
  • Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
  • All JSX used for rendering exists in the render method
  • The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
• If any new file was added I verified that:
  • The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
• If a new CSS style is added I verified that:
  • A similar style doesn't already exist
  • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)
• If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
• If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
• If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
• If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
• If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
• If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
• I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

🚀 Deployed to staging by https://github.com/thienlnam in version: 1.3.73-0 🚀

🚀 Deployed to production by https://github.com/mountiny in version: 1.3.73-1 🚀

🚀 Deployed to staging by https://github.com/thienlnam in version: 1.3.74-0 🚀

🚀 Deployed to production by https://github.com/chiragsalian in version: 1.3.74-3 🚀

@0xmiroslav @thienlnam Sorry to jump in on this fairly old issue, but any idea if a tracking issue (as suggested here) was created for the iOS issue. The code just links here.

I don't think issue was created for that. And not worth fixing for now I believe, focusing on other priority issues.